feat: add force_local_execution attribute to copy rules & macros for opt-out of local execution requirements #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16eec19 to
e448753
Compare
e448753 to
43932b1
Compare
alexeagle
reviewed
Oct 9, 2023
There was a problem hiding this comment.
There's not a use case for setting this differently on different targets, rather you need execution requirements to be based on how you're executing Bazel.
I think it needs to be a config setting with a custom flag, so you can opt-out of our execution requirements for the entire build?
dd6686a to
ae898fb
Compare
…opt-out of local execution requirements
ae898fb to
21672a8
Compare
|
replaced with #606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases where copy rules should run sandboxed or on remote executors. In these cases users should set
force_local_executionto False so the rules are not opinionated. Users can set custom execution requirements in their bazelrc via mnemonics if desired. Forcing local execution still seems like the best default for best performance by default when #466 is not an issue.Related issues & threads,
#466
https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1694892563112649
Type of change
Test plan