Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/bazel-gazelle
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.31.0
Choose a base ref
...
head repository: bazel-contrib/bazel-gazelle
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.31.1
Choose a head ref
  • 8 commits
  • 36 files changed
  • 5 contributors

Commits on May 28, 2023

  1. point sync.Once in walkConfig (#1532)

    Preventing concurrency bugs by making the loadOnce field of walkConfig a
    pointer to sync.Once to avoid instead copying the mutex within it.
    
    Fixes #1531
    
    Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
    jmhodges and fmeum authored May 28, 2023
    Configuration menu
    Copy the full SHA
    5492285 View commit details
    Browse the repository at this point in the history
  2. add copylock vet to nogo (#1534)

    Fixes #1532
    
    Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
    jmhodges and fmeum authored May 28, 2023
    Configuration menu
    Copy the full SHA
    3a1235c View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Configuration menu
    Copy the full SHA
    56b3f78 View commit details
    Browse the repository at this point in the history
  2. Add default directives for github.com/envoyproxy/protoc-gen-validate (#…

    …1553)
    
    * Add test
    
    * Add to default_gazelle_overrides.bzl
    mortenmj authored May 30, 2023
    Configuration menu
    Copy the full SHA
    0dbb617 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. cmd/gazelle: do not use the epoch as timestamp in diff output (#1552)

    * diff: do not use the epoch as timestamp
    
    * Fix tests
    
    * Update comment to mention epoch is special
    siddharthab authored May 31, 2023
    Configuration menu
    Copy the full SHA
    023974a View commit details
    Browse the repository at this point in the history
  2. fileinfo: fix not detecting 'unix' files to be OS specific (#1554)

    The build file generation logic works like this today:
    
    ```
    GenerateRules()
      package.go->*goTarget.addFiles
      package.go->getPlatformStringsAddFunction()
      fileinfo.go->isOSArchSpecific()
    ```
    
    Depending on whether the file has special Go build directives, Gazelle
    would use a different logic to include/exclude the file into the 'srcs'
    attribute of the Go targets.
    
    In #1512, we added support for 'unix' build directive but did not tell
    Gazelle to treat files with 'unix' file as OS specific file. This caused
    Gazelle to mismatch the OS in a later stage and exclude the needed file
    instead.
    
    Fix that logic and provide some additional tests to reinforce the
    fileinfo logic.
    
    Also added a small knob to print stdout of Gazelle when it's run under
    go_repository with `debug_mode` attribute set to True.  Most Gazelle's
    logs are printed to stdout and not stderr.
    sluongng authored May 31, 2023
    Configuration menu
    Copy the full SHA
    e770d46 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. language/go: Emit apparent repo name of rules_go in select keys (#1555)

    The constraint labels emitted as `select` keys now use the apparent name
    of the `rules_go` repository when using Bzlmod, with a fallback to
    `io_bazel_rules_go` if the `rules_go` module is not a declared
    `bazel_dep`.
    fmeum authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    af95853 View commit details
    Browse the repository at this point in the history
  2. Let bazel_deps replace Go deps (#1526)

    * Let `bazel_dep`s replace Go deps
    
    When a Go dependency is brought in both as a `bazel_dep` and as a
    regular Go dependency via e.g. go.mod, the `bazel_dep` repo should be
    used instead of creating a separate `go_repository`, which would risk
    duplicate packages.
    
    This is realized by registering every Bazel module with a
    `go_deps.from_file` tag as providing the Go module of the same version
    with the module path given in `go.mod`.
    
    Gazelle is aware of these tags and generates either a canonical label or
     a label using the apparent module repo name (the latter only for the
    root module and only if it directly depends on the `bazel_dep`).
    
    * Add warning
    
    * Add support for relaxed semvers
    
    * Add a dep on circl
    fmeum authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7feffe1 View commit details
    Browse the repository at this point in the history
Loading