Skip to content

Fix crash with more than one audio stream #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix crash with more than one audio stream #845

merged 2 commits into from
Dec 17, 2024

Conversation

g-maxime
Copy link
Collaborator

  • Ensure thread syncronisation
  • Use free instead of delete[] for strdup'ed data

Fixes #842

@g-maxime
Fix crash with more than one audio stream
59a1091 
- Ensure thread syncronisation
- Use free instead of delete[] for strdup'ed data

Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
@g-maxime g-maxime force-pushed the crash branch 5 times, most recently from 3395026 to 4bfc978 Compare December 16, 2024 22:13
@g-maxime
Fix CI
8095ade 
Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
@dericed dericed merged commit e2832ad into bavc:main Dec 17, 2024
10 checks passed
@JeromeMartinez JeromeMartinez deleted the crash branch December 17, 2024 09:49
@iamdamosuzuki iamdamosuzuki mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when processing files with 2 stereo audio channels (4 channels of audio) with qcli
2 participants
@g-maxime @dericed