Skip to content

Add beginner documentation #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

martin-schulze-vireso
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso commented Dec 27, 2020

Closes #358

The resulting output can be previewed here.
The companion repository for the example project can be found here: https://github.com/martin-schulze-vireso/bats-tutorial

@martin-schulze-vireso
Copy link
Member Author

martin-schulze-vireso commented Dec 27, 2020

This is still in draft mode but I already welcome test readers to share their feedback to avoid large rewrites further down the road.

@martin-schulze-vireso martin-schulze-vireso marked this pull request as ready for review January 22, 2021 22:56
@martin-schulze-vireso martin-schulze-vireso requested a review from a team as a code owner January 22, 2021 22:56
Copy link
Member

@sublimino sublimino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic walkthrough @martin-schulze-vireso, really clear writing and first-time journey 🎉

@btamayo
Copy link
Member

btamayo commented Feb 15, 2021

@martin-schulze-vireso Thanks so much for doing the research and work into typing this up!

Copy link
Member

@btamayo btamayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! We should do a re-review of this right after you're ready for review to double check

Make sure to also read the list of gotchas and the faq.

For this tutorial we are assuming you already have a project in a git repository and want to add tests.
Ultimately they should run in the CI environment but will also be started locally during development.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately they should run in the CI environment but will also be started locally during development.

This is a subjective thing - I believe that particular sentence is a bit out of place since the writing of the tests will be the same process whether or not it runs locally or in CI. Maybe we can add a separate TODO section for "Example of bats in CI"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant to express here is: Most editing/test development won't be done on the CI system. But automated tests are mainly intended to be run in a CI environment.
Of course, there are other workflows but in my view there are two main usecases:

  1. unsupervised batch execution, e.g. on the CI server
  2. interactive execution, e.g. on the developer machine

Obviously, there is are cases in between, like git bisect run.

@martin-schulze-vireso martin-schulze-vireso merged commit b81de28 into bats-core:master Apr 9, 2021
@sublimino
Copy link
Member

This is an awesome job to ship so much good, clear documentation @martin-schulze-vireso 🎉

@martin-schulze-vireso martin-schulze-vireso deleted the beginner_documentation branch April 9, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for beginners
4 participants