Skip to content

Small cleanups #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 20, 2020
Merged

Small cleanups #348

merged 6 commits into from
Sep 20, 2020

Conversation

martin-schulze-vireso
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso requested a review from a team as a code owner September 11, 2020 00:40
@martin-schulze-vireso martin-schulze-vireso changed the title Feature/cleanup Small cleanups Sep 11, 2020
This was referenced Sep 11, 2020
Merged
Merged
sublimino
sublimino approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@sublimino sublimino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, signed, fixed merge conflicts. Please confirm all as expected @martin-schulze-vireso and I'll merge 🙏

@martin-schulze-vireso
Copy link
Member Author

I'm in the go right now, so I cannot test. The changes looked good so far.

martin-schulze-vireso
martin-schulze-vireso commented Sep 17, 2020
View reviewed changes
@sublimino
Copy link
Member

Thank you @martin-schulze-vireso 🙏

@sublimino sublimino merged commit 18f574c into bats-core:master Sep 20, 2020
@martin-schulze-vireso martin-schulze-vireso deleted the feature/cleanup branch September 21, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sublimino sublimino sublimino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-schulze-vireso @sublimino