Skip to content

TAP13 compliant timing #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martin-schulze-vireso
Copy link
Member

This is a loos port of #127 to the current code layout.

Features:

  • measuring tests in ms (instead of (integer!) seconds as before)

  • adding a TAP13 formatter to avoid having to maintain multiple formats in the internals

  • I have reviewed the Contributor Guidelines.

  • I have reviewed the Code of Conduct and agree to abide by it

@martin-schulze-vireso martin-schulze-vireso requested a review from a team as a code owner July 26, 2020 00:14
Copy link
Member

@sublimino sublimino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @martin-schulze-vireso! I guess there are some doc updates needed if anybody would like to add to them, otherwise I'll add them when after merging (which will be sometime next week) 👍

@martin-schulze-vireso
Copy link
Member Author

Could you restart the travis run @sublimino ? There seem to have been some network issues.

@sublimino
Copy link
Member

Sure thing, restarted the build in Travis.

@sublimino sublimino force-pushed the feature/tap_compliant_timing branch from 3456c41 to b3357f9 Compare September 16, 2020 13:00
@sublimino
Copy link
Member

Rebased master, fixed shellchecks, and signed commits, LGTM :D

More great work shipping features and fixes @martin-schulze-vireso, thank you 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants