Checking permission and symbolic link file #32

xnum · 2017-10-21T16:08:17Z

If I download the zip file and unzip it on Windows, then upload to my workstation.
The permission of executable files and symbolic link file are broken.

If I download the zip file and unzip it on Windows, then upload to my workstation. The permission of executable files and symbolic link file are broken.

mbland · 2017-10-25T10:35:15Z

Sorry I haven't looked at this yet; super-slammed at work this week. Will try to take a look this weekend.

mbland · 2017-10-30T13:17:34Z

Sorry I didn't get to this this weekend; got slammed with another project. Will try to take a look later today.

mbland · 2017-10-31T12:38:13Z

install.sh

+# fix broken symbolic link file
+if [ ! -L "$PREFIX"/bin/bats ]; then
+    rm -f "$PREFIX"/bin/bats
+    ln -s "$PREFIX"/libexec/bats "$PREFIX"/bin/bats


I just tried this on Git for Windows, and for some reason ln -s doesn't want to cooperate:

$ ./install.sh ../usr ln: failed to create symbolic link '../usr/bin/bats': No such file or directory

Since the "link" is just a copy on this platform anyway, perhaps we should just use cp?

It seems some issue on NTFS
ref: 1
I got the solutionfrom 2
assign absolute path instead of relative path.
It works with git-bash.exe

mbland · 2017-11-13T13:57:45Z

install.sh

@@ -36,8 +36,9 @@ cp "$BATS_ROOT"/man/bats.7 "$PREFIX"/share/man/man7

 # fix broken symbolic link file
 if [ ! -L "$PREFIX"/bin/bats ]; then
-    rm -f "$PREFIX"/bin/bats
-    ln -s "$PREFIX"/libexec/bats "$PREFIX"/bin/bats
+    dir=$(readlink -e "$PREFIX")


Sorry for the delay, but confirmed locally this approach works. Just one thing: please enclose the $(readlink -e "$PREFIX") in double-quotes, in case the result includes spaces.

ntnn · 2017-11-13T14:33:07Z

@mbland As I've noted there are nomerous problems with this PR, why was it merged nonetheless?

See here:
https://github.com/bats-core/bats-core/pull/32/files/062160105638ebb101d867d1e9de160b00977e35#diff-3fbb47e318cd8802bd325e7da9aaabe8

This is quite off-putting for the project if even a simple install.sh as that can't be maintained properly.

I can't get a link to it, but one comment was about the absolute path - You never want an absolute path in an install script, as this will break the installation at least in source-based distributions.

No, that won't help either. Use ln -sf ../libexec/bats "$PREFIX/bin/bats".

For example in source-based distributions the install is done in a sandbox, e.g. $TMPDIR/bats/install and the source code is in $TMPDIR/bats/src. If install.sh $TMPDIR/bats/install is executed the symbolic link will point to $TMPDIR/bats/install/libexec/bats and break once the install tree has been copied to the root filesystem.

mbland · 2017-11-13T14:43:14Z

@ntnn I never saw that comment...that commit link doesn't show anything, and I can't find it anywhere else in the PR.

That is a fair point about the absolute path and using ln -sf instead. Sorry I missed it. Feel free to submit a follow-up PR.

ntnn · 2017-11-13T14:44:36Z

@mbland Huh, github is weird - I'll post a PR later this week. Thanks for answering so quickly.

xnum · 2017-11-13T14:49:42Z

sorry, but ln -sf couldn't solve the problem

mbland · 2017-11-13T14:53:04Z

Hmm, that is strange. It seems dependent on the path of the source, not on the path of the target. It's probably best just to copy the file rather than symlink it. Any reason not to do just that?

xnum · 2017-11-13T15:05:45Z

As I mentioned before, the problem is caused with NTFS probably
reference

copy the file is not working because bin/bats links to libexec/bats
and find libexec/bats-exec-test which not exists in bin dir.

Sidesteps the problems encountered during #32, and with running `bin/bats` on Windows environments that don't support symlinks.

dotmpe · 2018-06-05T14:13:17Z

Can we not adjust the installation, or package for windows?

Or at least keep and rename bin/bats script as bin/bats.win32 as long as there is no install but only ZIP for windows.

Closes #90. Closes #83. Closes #56. Closes #55. Closes #53. Resolves outstanding issues from #32. Per all these earlier issues and PRs: - The original bin/bats symlink was causing problems on Windows. - The attempted fix from #32 created problems for install.sh. - Per #90, changing bin/bats to a one-line script in #88 broke some Bats installations that rely on symlink schemes (such as when installed via https://github.com/basherpm/basher). For an idea why I wanted to abolish using any symlinks if I could for Windows's sake, see the following results I discovered during a search for "git symlink windows": - https://github.com/git-for-windows/git/wiki/Symbolic-Links - https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/ - libgit2/libgit2#4107 - https://stackoverflow.com/q/5917249 Using a method inspired by go-core.bash from https://github.com/mbland/go-script-bash, I was able to reliably compute the root of the Bats installation without using `readlink` by making use of `PWD` and `cd`. What's more, in the course of doing this, I realized libexec/bats didn't need `readlink` either, so I removed it, eliminating external dependencies and subshells. I also removed some extraneous variables and small bits of logic. On top of making install.sh, bin/bats, and libexec/bats more self-contained, resilient, and compact, the existing test suite (before the new installer and symlink tests) sped up significantly, running 0.6s-0.7s faster on my MacBook Pro (2.9 GHz Intel Core i5, 8GB RAM): Bash 3.2.57(1)-release before: 58 tests, 0 failures real 0m4.924s user 0m3.045s sys 0m1.798s Bash 3.2.57(1)-release after: 58 tests, 0 failures real 0m4.326s user 0m2.793s sys 0m1.508s Bash 4.4.23(1)-release before: 58 tests, 0 failures real 0m5.228s user 0m3.046s sys 0m1.952s Bash 4.4.23(1)-release after: 58 tests, 0 failures real 0m4.563s user 0m2.782s sys 0m1.614s

Closes #90. Closes #83. Closes #56. Closes #55. Closes #53. Resolves outstanding issues from #32. Per all these earlier issues and PRs: - The original bin/bats symlink was causing problems on Windows. - The attempted fix from #32 created problems for install.sh. - Per #90, changing bin/bats to a one-line script in #88 broke some Bats installations that rely on symlink schemes (such as when installed via https://github.com/basherpm/basher). For an idea why I wanted to abolish using any symlinks if I could for Windows's sake, see the following results I discovered during a search for "git symlink windows": - https://github.com/git-for-windows/git/wiki/Symbolic-Links - https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/ - libgit2/libgit2#4107 - https://stackoverflow.com/q/5917249 Using a method inspired by go-core.bash from https://github.com/mbland/go-script-bash, I was able to reliably compute the root of the Bats installation without using `readlink` by making use of `PWD` and `cd`. What's more, in the course of doing this, I realized libexec/bats didn't need `readlink` either, so I removed it, eliminating external dependencies and subshells. I also removed some extraneous variables and small bits of logic. On top of making install.sh, bin/bats, and libexec/bats more self-contained, resilient, and compact, the existing test suite (before the new installer and symlink tests) sped up significantly, running 0.6s-0.7s faster on my MacBook Pro (2.9 GHz Intel Core i5, 8GB RAM): Bash 3.2.57(1)-release before: 58 tests, 0 failures real 0m4.924s user 0m3.045s sys 0m1.798s Bash 3.2.57(1)-release after: 58 tests, 0 failures real 0m4.326s user 0m2.793s sys 0m1.508s Bash 4.4.23(1)-release before: 58 tests, 0 failures real 0m5.228s user 0m3.046s sys 0m1.952s Bash 4.4.23(1)-release after: 58 tests, 0 failures real 0m4.563s user 0m2.782s sys 0m1.614s Also tweaks the Dockerfile to update the symlink to point to bin/bats, not libexec/bats.

Closes #90. Closes #83. Closes #56. Closes #55. Closes #53. Resolves outstanding issues from #32. Per all these earlier issues and PRs: - The original bin/bats symlink was causing problems on Windows. - The attempted fix from #32 created problems for install.sh. - Per #90, changing bin/bats to a one-line script in #88 broke some Bats installations that rely on symlink schemes (such as when installed via https://github.com/basherpm/basher). For an idea of why I wanted to keep bin/bats as a script due to how symlinks complicate things on Windows, see the following results I discovered during a search for "git symlink windows": - https://github.com/git-for-windows/git/wiki/Symbolic-Links - https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/ - libgit2/libgit2#4107 - https://stackoverflow.com/q/5917249 In the course of applying these changes, I realized libexec/bats computed some extraneous variables, so I removed them, eliminating a few external processes and subshells. I also cleaned up other small bits of logic. On top of making install.sh, bin/bats, and libexec/bats more resilient and compact, the existing test suite (before adding the new test/installer.bats file) sped up significantly, running 0.6s-0.7s faster on my MacBook Pro (2.9 GHz Intel Core i5, 8GB RAM): Bash 3.2.57(1)-release before: 58 tests, 0 failures real 0m4.924s user 0m3.045s sys 0m1.798s Bash 3.2.57(1)-release after: 58 tests, 0 failures real 0m4.341s user 0m2.808s sys 0m1.540s Bash 4.4.23(1)-release before: 58 tests, 0 failures real 0m5.228s user 0m3.046s sys 0m1.952s Bash 4.4.23(1)-release after: 58 tests, 0 failures real 0m4.582s user 0m2.791s sys 0m1.643s Also tweaks the Dockerfile to update the symlink to point to bin/bats, not libexec/bats.

Checking permission and symbolic link file

7afdf57

If I download the zip file and unzip it on Windows, then upload to my workstation. The permission of executable files and symbolic link file are broken.

mbland requested a review from a team October 21, 2017 16:15

mbland self-assigned this Oct 21, 2017

mbland suggested changes Oct 31, 2017

View reviewed changes

Update install.sh

10db587

mbland reviewed Nov 13, 2017

View reviewed changes

Update install.sh

0621601

mbland approved these changes Nov 13, 2017

View reviewed changes

mbland merged commit b1da565 into bats-core:master Nov 13, 2017

mbland added a commit that referenced this pull request Jun 1, 2018

Replace bin/bats symlink with a one-line exec

842df84

Sidesteps the problems encountered during #32, and with running `bin/bats` on Windows environments that don't support symlinks.

mbland added a commit that referenced this pull request Jun 1, 2018

Replace bin/bats symlink with a one-line exec

c6e8f9e

Sidesteps the problems encountered during #32, and with running `bin/bats` on Windows environments that don't support symlinks.

mbland mentioned this pull request Jun 3, 2018

Adds next version changelog #66

Merged

2 tasks

dotmpe mentioned this pull request Jun 5, 2018

New file bin/bats breaks existing basher installations #90

Closed

mbland mentioned this pull request Jun 7, 2018

bin/bats, install.sh: Fix symlink bugs #91

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Checking permission and symbolic link file #32

Checking permission and symbolic link file #32

Uh oh!

xnum commented Oct 21, 2017

Uh oh!

mbland commented Oct 25, 2017

Uh oh!

mbland commented Oct 30, 2017

Uh oh!

mbland Oct 31, 2017

Uh oh!

xnum Oct 31, 2017

Uh oh!

mbland Nov 13, 2017

Uh oh!

ntnn commented Nov 13, 2017 •

edited

Loading

Uh oh!

mbland commented Nov 13, 2017

Uh oh!

ntnn commented Nov 13, 2017

Uh oh!

xnum commented Nov 13, 2017

Uh oh!

mbland commented Nov 13, 2017

Uh oh!

xnum commented Nov 13, 2017

Uh oh!

dotmpe commented Jun 5, 2018 •

edited

Loading

Uh oh!

Uh oh!

Checking permission and symbolic link file #32

Checking permission and symbolic link file #32

Uh oh!

Conversation

xnum commented Oct 21, 2017

Uh oh!

mbland commented Oct 25, 2017

Uh oh!

mbland commented Oct 30, 2017

Uh oh!

mbland Oct 31, 2017

Choose a reason for hiding this comment

Uh oh!

xnum Oct 31, 2017

Choose a reason for hiding this comment

Uh oh!

mbland Nov 13, 2017

Choose a reason for hiding this comment

Uh oh!

ntnn commented Nov 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbland commented Nov 13, 2017

Uh oh!

ntnn commented Nov 13, 2017

Uh oh!

xnum commented Nov 13, 2017

Uh oh!

mbland commented Nov 13, 2017

Uh oh!

xnum commented Nov 13, 2017

Uh oh!

dotmpe commented Jun 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ntnn commented Nov 13, 2017 •

edited

Loading

dotmpe commented Jun 5, 2018 •

edited

Loading