-
Notifications
You must be signed in to change notification settings - Fork 443
Upgrade detik to 1.3.2 #1017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade detik to 1.3.2 #1017
Conversation
Upgrade reference to detik in Dockerfile from 1.3.1 to 1.3.2.
can you please add a line in the changelog? like here |
Update the bats-detik change line to indicate upgrade to 1.3.2, instead of 1.3.1 (also unreleased).
I updated the CHANGELOG.md in the unreleased section. It already listed an upgrade to detik 1.3.1 so I replaced that line with an upgrade to 1.3.2. |
thanks
what do you mean by this? bats is the binary itself and detik is one of the libraries (plugins or ext if we want to call it in another way) that have different version and the 1.3.2 is the latest one of detik while 1.11 is the latest of bats. |
What I mean is that bats-core is the source of |
AFAIK the releases to dockerhub are only done on tags and latest is updated with the last release. Sometimes I retrigger releases to pull in newer alpine version for some security fixes, which might make an older version latest but we never time travelled into the future with that. I just checked for
Having cleared this up, I think this is good to go. Thanks for your contribution! |
Thanks for looking into this. I see what happened on my end now - detik.bash didn't change between v1.3.0 and v1.3.1, so the sha1sum from the docker image correctly matched by tags. Looking at the other files like you did would have cleared it up for me. All good now. |
Upgrade reference to detik in Dockerfile from 1.3.1 to 1.3.2 (released July 17). closes #1018