Skip to content

Conversation

youngderekm
Copy link
Contributor

@youngderekm youngderekm commented Nov 19, 2024

Upgrade reference to detik in Dockerfile from 1.3.1 to 1.3.2 (released July 17). closes #1018

Upgrade reference to detik in Dockerfile from 1.3.1 to 1.3.2.
@brokenpip3
Copy link
Contributor

brokenpip3 commented Nov 19, 2024

can you please add a line in the changelog? like here
(thanks!)

Update the bats-detik change line to indicate upgrade to 1.3.2, instead of 1.3.1 (also unreleased).
@youngderekm
Copy link
Contributor Author

I updated the CHANGELOG.md in the unreleased section. It already listed an upgrade to detik 1.3.1 so I replaced that line with an upgrade to 1.3.2.
However, from what I can tell, the docker image (bats/bats) is using bats-core 1.11.0 but detik 1.3.1 (which must be the unreleased version?).

@brokenpip3
Copy link
Contributor

I updated the CHANGELOG.md in the unreleased section. It already listed an upgrade to detik 1.3.1 so I replaced that line with an upgrade to 1.3.2.

thanks

However, from what I can tell, the docker image (bats/bats) is using bats-core 1.11.0 but detik 1.3.1 (which must be the unreleased version?).

what do you mean by this? bats is the binary itself and detik is one of the libraries (plugins or ext if we want to call it in another way) that have different version and the 1.3.2 is the latest one of detik while 1.11 is the latest of bats.
Maybe I'm misunderstood your question :)

@youngderekm
Copy link
Contributor Author

However, from what I can tell, the docker image (bats/bats) is using bats-core 1.11.0 but detik 1.3.1 (which must be the unreleased version?).

what do you mean by this? bats is the binary itself and detik is one of the libraries (plugins or ext if we want to call it in another way) that have different version and the 1.3.2 is the latest one of detik while 1.11 is the latest of bats. Maybe I'm misunderstood your question :)

What I mean is that bats-core is the source of bats (the binary) and also the docker image bats/bats:latest (the Dockerfile). I was wondering if bats/bats:latest was built/pushed from the master branch, rather than the v1.11.0 tag, and built after v1.11.0 was released. It looks to me like the md5sum of detik.bash that is in the container matches the v1.3.1 version from bats-detik, even though bats-detik was upgraded to v1.3.1 after the 1.11.0 release of bats-core (Dockerfile from v1.11.0 specifies detik v1.3.0). Maybe I'm mistaken though. Either way, the Dockerfile should now have the latest detik.

@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Nov 27, 2024

AFAIK the releases to dockerhub are only done on tags and latest is updated with the last release. Sometimes I retrigger releases to pull in newer alpine version for some security fixes, which might make an older version latest but we never time travelled into the future with that.

I just checked for bats/bats:latest and got these sha1sums which are consistent with bats-detik v1.3.0 (which is also whats in the Dockerfile for bats v1.11.0 and in the image under /opt/bats/Dockerfile):

6ee30dba1ec5d563f63a6c8c8c22c770106bb0e3  detik.bash
26875234493ae5b10a97c122dd70c8ad8f13f46a  linter.bash
0853d533f0f32501620f8e06f237492b05fde797  utils.bash

Having cleared this up, I think this is good to go. Thanks for your contribution!

@martin-schulze-vireso martin-schulze-vireso merged commit ab3c99b into bats-core:master Nov 27, 2024
55 checks passed
@youngderekm
Copy link
Contributor Author

Thanks for looking into this. I see what happened on my end now - detik.bash didn't change between v1.3.0 and v1.3.1, so the sha1sum from the docker image correctly matched by tags. Looking at the other files like you did would have cleared it up for me. All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bats/bats docker image is using older version of detik
3 participants