fix: use $BATS_LIBDIR instead of hardcoded lib in bats-gather-tests #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pscn
commented
Sep 4, 2024
- [ I'm an idiot] I have reviewed the Contributor Guidelines.
- [PR without testing... PFFF... ] I have reviewed the Code of Conduct and agree to abide by it
|
I started the tests, can you drop a line in the changelog? check the already merged pr to check how to do it. |
pscn
added a commit
to pscn/bats-core
that referenced
this pull request
Sep 4, 2024
|
I wonder why the tests did not catch this? IIRC there is a test with different lib path. |
bc91355 to
13df235
Compare
|
I cleaned up the history and added another test that should reproduce the issue. Thanks for your contribution! |
13df235 to
53ca314
Compare
martin-schulze-vireso
approved these changes
Sep 13, 2024
73d0e61 to
57b5ac5
Compare
57b5ac5 to
8629092
Compare
fd3f217
into
bats-core:master
53 of 55 checks passed
maybe in our github action we always run bats from the repo and when we use the nodejs install it will always it in the same path? we may want to add a different path matrix by testing the install.sh installation method |
|
I added the Tests here and fixed them in #990 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.