Skip to content

prevent bash from trying to run bats from workdir #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2024
Merged

prevent bash from trying to run bats from workdir #920

merged 2 commits into from
Jun 12, 2024

Conversation

docwhat
Copy link
Contributor

@docwhat docwhat commented May 10, 2024

By specifying the explicit paths, we prevent bash from trying to load bats from the the current working directory.

Example:

$ mkdir -p bats; docker run --rm --mount="type=bind,src=$PWD,dst=/code,readonly" bats/bats
bats: bats: Is a directory

@docwhat docwhat requested a review from a team as a code owner May 10, 2024 14:50
@docwhat docwhat force-pushed the fix-entrypoint-paths branch from fa955bb to d0fcd31 Compare May 10, 2024 16:13
@docwhat
prevent bash from trying to run bats from workdir
a4f2e1a 
By specifying the explicit paths, we prevent `bash` from trying to load `bats` from the the current working directory.

Example:

```sh
$ mkdir -p bats; docker run --rm --mount="type=bind,src=$PWD,dst=/code,readonly" bats/bats
bats: bats: Is a directory
```
@docwhat docwhat force-pushed the fix-entrypoint-paths branch from d0fcd31 to a4f2e1a Compare May 11, 2024 00:03
@martin-schulze-vireso martin-schulze-vireso merged commit 190c7c9 into bats-core:master Jun 12, 2024
@martin-schulze-vireso
Copy link
Member

Thanks for your contribution.

@docwhat docwhat deleted the fix-entrypoint-paths branch July 5, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-schulze-vireso martin-schulze-vireso martin-schulze-vireso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@docwhat @martin-schulze-vireso