Skip to content

Remove unused BATS_TEST_FILTER #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2024
Merged

Remove unused BATS_TEST_FILTER #907

merged 2 commits into from
Sep 13, 2024

Conversation

debarshiray
Copy link
Contributor

Fallout from 67822e2 and
9d5ecdb

@debarshiray debarshiray requested a review from a team as a code owner April 24, 2024 22:16
debarshiray added a commit to debarshiray/bats-core that referenced this pull request Apr 24, 2024
@debarshiray
Add newline at end of file
2d59a8e 
Some editors like GNU Emacs insist on adding the newline at end of file,
if it's missing, which leads to noise when looking at the actual code
changes.

bats-core#907
debarshiray added a commit to debarshiray/bats-core that referenced this pull request Apr 24, 2024
@debarshiray
Remove unused BATS_TEST_FILTER
7c09753 
Fallout from 67822e2 and
9d5ecdb

bats-core#907
@debarshiray debarshiray force-pushed the wip/rishi/BATS_TEST_FILTER-unused branch from 52cc3f2 to 7c09753 Compare April 24, 2024 22:19
@debarshiray debarshiray mentioned this pull request Apr 24, 2024
Merged
2 tasks
martin-schulze-vireso added a commit to debarshiray/bats-core that referenced this pull request May 4, 2024
@martin-schulze-vireso
Add changelog entry for bats-core#907
32b1bb3
@debarshiray
Copy link
Contributor Author

Thanks for adding the docs/CHANGELOG.md entry, @martin-schulze-vireso I wasn't sure if it's worth adding or skipping the test with the no changelog label.

@martin-schulze-vireso
Copy link
Member

I am unsure as well and have half a mind of folding this into your other PR.

@debarshiray
Copy link
Contributor Author

I am unsure as well and have half a mind of folding this into your other PR.

Whatever you decide is fine with me. :)

@debarshiray
Copy link
Contributor Author

Looks like I need to rebase this against master. I will take a look at it soon.

debarshiray added a commit to debarshiray/bats-core that referenced this pull request Aug 12, 2024
@debarshiray
Remove unused BATS_TEST_FILTER
a3ba774 
Fallout from 67822e2 and
9d5ecdb

bats-core#907
@debarshiray debarshiray force-pushed the wip/rishi/BATS_TEST_FILTER-unused branch from 32b1bb3 to a3ba774 Compare August 12, 2024 20:03
@debarshiray
Copy link
Contributor Author

Looks like I need to rebase this against master. I will take a look at it soon.

Done

@martin-schulze-vireso martin-schulze-vireso force-pushed the wip/rishi/BATS_TEST_FILTER-unused branch from a3ba774 to bcaf933 Compare September 13, 2024 13:39
@martin-schulze-vireso
Copy link
Member

I rebased again and added a changelog entry. Thanks for you contribution!

@martin-schulze-vireso martin-schulze-vireso merged commit 9af2573 into bats-core:master Sep 13, 2024
54 checks passed
@debarshiray debarshiray deleted the wip/rishi/BATS_TEST_FILTER-unused branch September 27, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-schulze-vireso martin-schulze-vireso martin-schulze-vireso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debarshiray @martin-schulze-vireso