Adds next version changelog #66
Conversation
Two things here:
- judging by the "Added ..." lines of the changelog, this justifies pumping to 0.5.0 instead of a patch release, ie 0.4.1
- I changed the order of mentioning changes, I mention first the new stuff ("Added..."), then the improved stuff and then the bug fixes.
|
Awesome @tterranigma, thanks! Added this to the 0.5.0 milestone as the final step before release. |
README.md
Outdated
| ## Version history | ||
| ## Version | ||
|
|
||
| *0.5.0* (April xx, 2018) |
README.md
Outdated
| * Added support for test scripts that have the [unofficial strict mode](redsymbol.net/articles/unofficial-bash-strict-mode/) enabled. | ||
| * Added support for tabs in test names. | ||
| * Improved stability on Windows and macOS platforms. | ||
| * Fixed an installation bug where if Bats was uploaded from Windows to a server installation would fail ([commit](7afdf57bd3cbd216f6dd98b2112f2cf4fa521870)) |
There was a problem hiding this comment.
Can you use the bare commit number here? The link appears broken, and GitHub should auto-link it correctly.
README.md
Outdated
| * Added support for tabs in test names. | ||
| * Improved stability on Windows and macOS platforms. | ||
| * Fixed an installation bug where if Bats was uploaded from Windows to a server installation would fail ([commit](7afdf57bd3cbd216f6dd98b2112f2cf4fa521870)) | ||
| * Fixed TAP compliance for skipped tests |
There was a problem hiding this comment.
Some more items to add:
- Massive performance improvements, especially on Windows (Fix macOS/Bash 3.2 breakage; eliminate subshells from exec-test, preprocess #8)
- Workarounds for inconsistent behavior between Bash versions (Show errors when Bash EXIT trap fires without ERR #82)
- Workaround for preserving stack info after calling an exported function under Bash < 4.4 (Emit correct trace after calling exported function #87)
It might also be worth noting at the top that 0.5.0 generally preserves compatibility with 0.4.0, but with some compatibility improvements and a massive performance boost. In other words:
- all existing tests should remain compatible
- tests that might've failed or exhibited unexpected behavior on earlier versions of Bash should now also pass or behave as expected
|
@mbland you've been powering through the backlog, awesome work :D I've updated this PR with your comments. |
README.md
Outdated
| * Workaround for preserving stack info after calling an exported function under Bash < 4.4 (#87) | ||
| * Fixed TAP compliance for skipped tests | ||
| * Added support for tabs in test names. | ||
| * Fixed an installation bug where if Bats was uploaded from Windows to a server installation would fail ([commit](https://github.com/bats-core/bats-core/commit/7afdf57bd3cbd216f6dd98b2112f2cf4fa521870)) |
|
Last changes are in place. This looks like a solid changelog. How about tagging 0.5.0? That would be really awesome.. Moving almost! |
q.bats
Outdated
| @@ -0,0 +1,9 @@ | |||
| #!/usr/bin/env bats | |||
There was a problem hiding this comment.
This file looks extraneous. Remove it?
README.md
Outdated
| @@ -384,6 +384,24 @@ on the wiki. | |||
|
|
|||
| Bats is [SemVer compliant](https://semver.org/). | |||
|
|
|||
| *0.5.0* (June xx, 2018) | |||
There was a problem hiding this comment.
This should be 1.0.0 now. Let's go ahead and put June 8, 2018 in there, too. (If we slip, I can tweak it when it's time to tag and release per #16.)
README.md
Outdated
| @@ -384,6 +384,24 @@ on the wiki. | |||
|
|
|||
| Bats is [SemVer compliant](https://semver.org/). | |||
|
|
|||
| *0.5.0* (June xx, 2018) | |||
|
|
|||
| `0.5.0` generally preserves compatibility with `0.4.0`, but with some Bash compatibility improvements and a massive performance boost. In other words: | |||
| * Workaround for preserving stack info after calling an exported function under Bash < 4.4 (#87) | ||
| * Fixed TAP compliance for skipped tests | ||
| * Added support for tabs in test names. | ||
| * Fixed an installation bug where if Bats was uploaded from Windows to a server installation would fail (#88) |
There was a problem hiding this comment.
I meant that the new line should replace this one, but no matter; I'll delete the old line during the cleanup pass.
| * Workaround for preserving stack info after calling an exported function under Bash < 4.4 (#87) | ||
| * Fixed TAP compliance for skipped tests | ||
| * Added support for tabs in test names. | ||
| * Fixed an installation bug where if Bats was uploaded from Windows to a server installation would fail (#88) |
There was a problem hiding this comment.
I meant that the new line should replace this one, but no matter; I'll delete the old line during the cleanup pass.
Two things here:
judging by the "Added ..." lines of the changelog, this justifies pumping to 0.5.0 instead of a patch release, ie 0.4.1
I changed the order of mentioning changes, I mention first the new stuff ("Added..."), then the improved stuff and then the bug fixes.
I have reviewed the Contributor Guidelines.
I have reviewed the Code of Conduct and agree to abide by it