This repository was archived by the owner on Feb 18, 2023. It is now read-only.
sipauth: fix test_sip_auth_encode_md5 and add test_sip_auth_encode_sha256 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreimers
reviewed
Jan 21, 2022
| @@ -36,7 +36,7 @@ static int test_sip_auth_encode(void) | |||
| "10.0.0.1:37589;branch=z9hG4bK5625ce6f310a0fc8;rport=13718;" | |||
| "received=10.0.0.2\r\n" | |||
| "WWW-Authenticate: Digest realm=\"example.net\", " | |||
| "nonce=\"YZlVk2GZVGegVBZVKaMHpnxmUA+QyoSl\"\r\n" | |||
| "nonce=\"YZlVk2GZVGegVBZVKaMHpnxmUA+QyoSl\" algorithm=MD5\r\n" | |||
There was a problem hiding this comment.
Without algorithm is valid test case too and should fallback to MD5 I think.
There was a problem hiding this comment.
For reference:
https://datatracker.ietf.org/doc/html/rfc2617#section-3.1.3
3.1.3 Representation of digest values
An optional header allows the server to specify the algorithm used to
create the checksum or digest. By default the MD5 algorithm is used
and that is the only algorithm described in this document.
...
algorithm
A string indicating a pair of algorithms used to produce the digest
and a checksum. If this is not present it is assumed to be "MD5".
If the algorithm is not understood, the challenge should be ignored
(and a different one used, if there is more than one).
There was a problem hiding this comment.
I agree, MD5 should be taken as the default. For the moment let's keep the branches open, I'll try to work on them as soon as possible.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed test for MD5, introduced test for SHA-256.