-
Notifications
You must be signed in to change notification settings - Fork 6
IPv6 link local support #20
Conversation
@sreimers Currently trying to increase the test coverage of net.c. Does the test machine have a network interface with IPv6ll, IPv4 address and which is UP? |
I think we should/can not rely on this for unit tests. Maybe we could make a new test category like |
You mean a new option in main.c like |
src/net.c
Outdated
@@ -40,3 +56,47 @@ int test_net_dst_source_addr_get(void) | |||
out: | |||
return err; | |||
} | |||
|
|||
|
|||
int test_net_dst_is_source_addr(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this test needed since baresip/re@56d21fa removed net_dst_is_source_addr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, sorry. Now I will work on the tests. You're right! The last commit is obsolete and also the test.
Now I have
The boundary of 54.3% is not reached in master. "build (clang, macos-latest)" fails. Maybe again the udp_connect() to a destination with unset port?
|
Put IPv6ll tests into new test group "network specific tests". Github workflow for code coverage reaches now 54.3%. |
@sreimers Fixed the test. Please re-run the workflow! |
No description provided.