Skip to content

aubuf: remove unused private function plot_underrun() #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

aubuf: remove unused private function plot_underrun() #1380

merged 1 commit into from
Jul 30, 2025

Conversation

alfredh
Copy link
Contributor

@alfredh alfredh commented Jul 30, 2025

Please take a look at this PR.

It looks like the private function in AJB plot_underrun() is not used anywhere.
Proposal to remove it or start using it if that was a bug.

@cspiel1
Copy link
Collaborator

cspiel1 commented Jul 30, 2025

The usage was removed with fe0c201.

I'll have a closer look.

@cspiel1
Copy link
Collaborator

cspiel1 commented Jul 30, 2025

Was replaced by RE_TRACE_ID_INSTANT("aubuf", "underrun", ab->id);. This PR can be merged.

@sreimers sreimers merged commit cee77b6 into main Jul 30, 2025
38 checks passed
@sreimers sreimers deleted the aubuf_plot_underrun branch July 30, 2025 12:29
@BrewTestBot BrewTestBot mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfredh @cspiel1 @sreimers