100rel improvements #1333
Merged
100rel improvements #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff419a8 to
a847f75
Compare
a847f75 to
83fb352
Compare
As required by RFC 3262 section 4. Further, the progress handler is now only called when this check (and others) have passed, which aligns much better with the RFC - invalid responses may not be processed further.
83fb352 to
61de9bf
Compare
As required by RFC 3262 section 3: The UAS MUST NOT send a second reliable provisional response until the first is acknowledged. After the first, it is RECOMMENDED that the UAS not send an additional reliable provisional response until the previous is acknowledged.
61de9bf to
1f6888f
Compare
|
After this commit there is a new warning when running retest: The TEST_ERR() macro does not seem to be working as expected, the local "int err" value is not set ... |
|
@alfredh Sorry about that, I'll provide a fix soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As required by RFC 3262 section 3:
The UAS MUST NOT send a second reliable provisional response until the
first is acknowledged. After the first, it is RECOMMENDED that the UAS
not send an additional reliable provisional response until the previous
is acknowledged.
As required by RFC 3262 section 4. Further, the progress handler is now
only called when this check (and others) have passed, which aligns much
better with the RFC - invalid responses may not be processed further.
Related: