sess,request: deref request and ctrans immediately #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if no provisional response was received for the request.
fe6d9bc to
6542abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... if no provisional response was received for the request.
This caused the following undesirable behavior with UDP: A user starts a call, doesn't get a response and so the user cancels it. Shortly after, the recipient of the INVITE goes online, receives a UDP retransmission of the INVITE and sends an answer. The user could suddenly be in a call they thought they cancelled.
With this change, if a SIP session is terminated, the underlying
requestandctransare destroyed immediately if no response was received at all.For reliable transports this does not happen because a transport error would occur and there are no retransmissions.