Add const-correctness to argv #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo
In our project, we use some wrappers around boost_program_options and have tests for them, like that:
I decided to switch to Popl, as it is more portable than Boost, has no RTTI requirements, has less weight etc. In order to continue to use these tests, I had to add const-correctness to Popl, as I removing it from array initialization is forbidden by C++ standard:
I find that change quite useful, so I open a pull request.