Build: use lerna 2.x beta #3509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.79%@@ master #3509 diff @@
==========================================
Files 194 194
Lines 9637 9515 -122
Methods 1101 1073 -28
Messages 0 0
Branches 2203 2163 -40
==========================================
- Hits 8472 8354 -118
+ Misses 1165 1161 -4
Partials 0 0
|
| } | ||
| }, | ||
| "bootstrapConfig": { | ||
| "ignore": "babel-runtime" |
There was a problem hiding this comment.
ignore babel-runtime which should replace the rm -rf packages/*/node_modules/babel-runtime above
3d10770 to
41fbde6
Compare
|
Great finally passed - still the question I brought up earlier though |
| make build | ||
| cd packages/babel-runtime; \ | ||
| npm install; \ |
There was a problem hiding this comment.
Ignoring babel-runtime means it doesn't npm install for babel-runtime which sucks
lerna changelog update
| @@ -52,15 +52,14 @@ publish: | |||
| rm -rf packages/*/lib | |||
| BABEL_ENV=production make build-dist | |||
| make test | |||
| ./node_modules/.bin/lerna publish | |||
| ./node_modules/.bin/lerna publish --only-explicit-updates | |||
There was a problem hiding this comment.
This emulates behavior in lerna 1.x
$ lerna updated --only-explicit-updates
Lerna v2.0.0-beta.23
Checking for updated packages...
- babel-code-frame
- babel-generator
- babel-plugin-transform-es2015-unicode-regex
- babel-plugin-transform-react-jsx-self
- babel-preset-es2016
- babel-preset-react
- babel-preset-stage-2
- babel-preset-stage-3
without the flag, it checks all dependencies and thus updates all packages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interesting thing with the updates to
lerna updatedin 2.x.Maybe we do want an option to only update the packages that changed and not account for the sub-dependencies, especially since we are using
^anyway?Adds repository field to babel-regenerator-runtimechanges package.json and in the end all packages depend on babel-regenetor-runtime because of babel-runtime. So simply changing that field inpackage.jsoncauses all to update which is kind of annoying atm.