fix: finally causes unexpected return value
#17366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liuxingbaoyu
commented
Jun 4, 2025
| Q | A |
|---|---|
| Fixed Issues? | Fixes #17365 |
| Patch: Bug Fix? | √ |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | √ |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
liuxingbaoyu
commented
Jun 4, 2025
Comment on lines
+331
to
+336
| // if ((method = entry[4]!)) { | ||
| // arg = entry[5]; | ||
| // } else { | ||
| // method = OperatorType.Jump; | ||
| // arg = entry[3]; | ||
| // } |
There was a problem hiding this comment.
Do you think this is useful?
There was a problem hiding this comment.
Maybe add a note that the following line is a golfed version of this snippet? Otherwise at first glance they look like some unused code ready for the cleanup.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59530 |
JLHwung
approved these changes
Jun 4, 2025
nicolo-ribaudo
approved these changes
Jun 5, 2025
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.