Skip to content

Set binary operator typings to a more precise union #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Set binary operator typings to a more precise union #17361

merged 1 commit into from
Jun 3, 2025

Conversation

RReverser
Copy link
Member

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Very simple typing change to generate operator: "=" | "+=" | ... in TS definitions instead of operator: string.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59519

JLHwung
JLHwung approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

liuxingbaoyu
liuxingbaoyu approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: types labels Jun 3, 2025
@JLHwung JLHwung merged commit 5293ce0 into babel:main Jun 3, 2025
58 checks passed
@liuxingbaoyu liuxingbaoyu added PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release and removed PR: Internal 🏠 A type of pull request used for our changelog categories labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
pkg: types PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RReverser @babel-bot @JLHwung @liuxingbaoyu