Skip to content

fix(converter): Remove abstract modifiers in class declaration to expression conversion #17321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2025
Merged

fix(converter): Remove abstract modifiers in class declaration to expression conversion #17321

merged 2 commits into from
May 21, 2025

Conversation

magic-akari
Copy link
Contributor

@magic-akari magic-akari commented May 19, 2025 •
edited
Loading

Q                       A
Fixed Issues? Fixes #17320
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@magic-akari magic-akari changed the title fix(toExpression): ensure abstract modifiers are not set on class exp… fix(toExpression): ensure abstract modifiers are not set on class expressions May 19, 2025
@babel-bot
Copy link
Collaborator

babel-bot commented May 19, 2025 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59367

@magic-akari
Copy link
Contributor Author

https://babeljs.io/repl/build/59352#?browsers=&build=&builtIns=false&corejs=3.21&spec=false&loose=false&code_lz=GYVwdgxgLglg9mABBANgQwM4YCIFMIAUUaATgOa5QA0yCUuAHlAJSIDeAvgFBcACqmHPi5oARhigk00ZOiyIAwuy6JEEtLAiJgcOIgC82tCgy4A3F25A&forceAllTransforms=false&modules=false&shippedProposals=false&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=&prettier=false&targets=&version=7.27.2%2Bpr.17321&externalPlugins=%40babel%2Fplugin-proposal-decorators%407.27.1%2C%40babel%2Fplugin-syntax-typescript%407.27.1&assumptions=%7B%7D

@magic-akari
Copy link
Contributor Author

Not sure where to add the test files.

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 19, 2025
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented May 19, 2025 •
edited
Loading

I would add one in the decorators plugin, in the packages/babel-plugin-proposal-decorators/test/fixtures/2023-11-typescript folder but with the syntax rather than transform plugin, and a unit test in packages/babel-types/test/converters.js

@magic-akari magic-akari changed the title fix(toExpression): ensure abstract modifiers are not set on class expressions fix(converter): Remove abstract modifiers in class declaration to expression conversion May 21, 2025
@nicolo-ribaudo nicolo-ribaudo merged commit 253a64b into babel:main May 21, 2025
57 checks passed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 21, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malformed generated TypeScript with class decorator, plugin-syntax-typescript, and a decorated abstract class
4 participants
@magic-akari @babel-bot @nicolo-ribaudo @JLHwung