fix: support named evaluation for using declaration #17317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59349 |
nicolo-ribaudo
approved these changes
May 16, 2025
Comment on lines
5
to
10
| var _usingCtx = babelHelpers.usingCtx(); | ||
| const foo = _usingCtx.u((_m = class { | ||
| static [Symbol$dispose]() { | ||
| log.push(`${foo.name} is disposed`); | ||
| } | ||
| }, babelHelpers.setFunctionName(_m, "foo"))); |
There was a problem hiding this comment.
_usingCtx.u(babelHelpers.setFunctionName(class {}, "foo")))
Is there any difference with this?
liuxingbaoyu
approved these changes
May 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although adding name to class id generally works, in this PR we choose the
setFunctionNameapproach becauseusing ... = class {}is probably not very popular, I think it is acceptable to trade off output size for spec compliance here.