[babel 8] Do not replace global regeneratorRuntime references in regenerator transform
#17237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed75813 to
f2b3a0f
Compare
f2b3a0f to
5fc2fa4
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59418 |
375a9f7 to
8bb6725
Compare
50fa1b7 to
d18276c
Compare
1a02a48 to
bd10fa0
Compare
|
Are there any benefits to using |
That maybe the problem is in one of your dependencies, and you don't have direct control on it. But yeah I mention in the migration docs that ideally people should not rely on an implicit global. |
liuxingbaoyu
approved these changes
May 14, 2025
e9768d3 to
99546ea
Compare
312f887 to
1044027
Compare
This was referenced May 14, 2025
99546ea to
b2db8aa
Compare
67f11f9 to
1fdd23f
Compare
99c2cd6 to
9bb58ec
Compare
f83a619 to
be67be4
Compare
nicolo-ribaudo
added a commit
that referenced
this pull request
May 29, 2025
…generator transform (#17237)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2In Babel 7 it's safe to replace
regeneratorRuntimereferences not injected by Babel with a call to the helper, because it has the same behavior. To avoid having to provide backwards compatibility across major versions, this PR changes the Babel 8 behavior to simply not do that. If somebody has aregeneratorRuntimeglobal reference in their code they will have to usebabel-plugin-polyfill-regenerator, which injects an import to the original (thus, with the semantics that the user expected when they wrote that code)regenerator-runtimepackage.