[Babel 8] Align esmodules: true behaviour to intersect #17188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only snapshot the base esmodules: true query. The other queries can be represented as changes based on the base query.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58876 |
JLHwung
commented
Mar 17, 2025
| "safari": "10.1", | ||
| "samsung": "8.2" | ||
| "safari": "18.2", | ||
| "samsung": "26" |
There was a problem hiding this comment.
These test cases are updated because in Babel 8 a single esmodules: true will be ignored as the browsers in the defaults browserslist queries all support ESM.
|
Agree with also keeping |
|
Docs PR is ready now: babel/website#3069, ptal. |
nicolo-ribaudo
approved these changes
Mar 20, 2025
liuxingbaoyu
approved these changes
Mar 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2In this PR we change the
esmodules: truebehaviour in Babel 8 toesmodules: "intersect". I didn't remove theesmodules: "intersect"option because I think it is more straightforward thanesmodules: true.I also restructured the tests: the snapshots are replaced by static base queries plus various value updates.