Skip to content

fix: Correctly generate abstract override #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix: Correctly generate abstract override #17153

merged 1 commit into from
Feb 26, 2025

Conversation

liuxingbaoyu
Copy link
Member

Q                       A
Fixed Issues? Fixes #17152
Patch: Bug Fix? √
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? √
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58773

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator area: typescript labels Feb 26, 2025
@jzhan-canva
Copy link

thanks for the prompt fix, can't wait to have this merged

@JLHwung JLHwung merged commit 1943a7a into babel:main Feb 26, 2025
55 checks passed
@Tobbe Tobbe mentioned this pull request Mar 15, 2025
Merged
Tobbe added a commit to redwoodjs/graphql that referenced this pull request Mar 15, 2025
@Tobbe
deps(@babel/generator): Bump to 7.26.10 (#11983)
9fb1ef8 
Changes since the last version:

babel/babel#17153
babel/babel#17062
babel/babel#17028
babel/babel#17019
babel/babel#16958
babel/babel#16959
babel/babel#16948
babel/babel#16850
babel/babel#16841
babel/babel#16708
babel/babel#16732
Tobbe added a commit to redwoodjs/graphql that referenced this pull request Mar 25, 2025
@Tobbe
deps(@babel/generator): Bump to 7.26.10 (#11983)
8ce6276 
Changes since the last version:

babel/babel#17153
babel/babel#17062
babel/babel#17028
babel/babel#17019
babel/babel#16958
babel/babel#16959
babel/babel#16948
babel/babel#16850
babel/babel#16841
babel/babel#16708
babel/babel#16732
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 29, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/plugin-syntax-typescript generates illegal typescript code
5 participants
@liuxingbaoyu @babel-bot @jzhan-canva @nicolo-ribaudo @JLHwung