Skip to content

[babel 8] Deprecate uppercase builders #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 26, 2025
Merged

[babel 8] Deprecate uppercase builders #17133

merged 8 commits into from
Mar 26, 2025

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Closes #17129
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added the PR: Deprecation (next major) 📢 A type of pull request used for our changelog categories for next major release label Feb 14, 2025
@nicolo-ribaudo nicolo-ribaudo marked this pull request as draft February 14, 2025 11:39
@nicolo-ribaudo
Copy link
Member Author

Marking as draft until when I add a test

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 14, 2025 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58929

@nicolo-ribaudo nicolo-ribaudo changed the title [babel 8] Deprecate uppercase builders [babel 8] Deprecate uppercase builders, and remove deprecated ones Feb 14, 2025
@nicolo-ribaudo nicolo-ribaudo changed the title [babel 8] Deprecate uppercase builders, and remove deprecated ones [babel 8] Deprecate uppercase builders Feb 14, 2025
@nicolo-ribaudo nicolo-ribaudo force-pushed the uppercase-builders-deprecate branch from ca09cf0 to 76c9f7b Compare March 21, 2025 11:35
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review March 21, 2025 11:38
@nicolo-ribaudo nicolo-ribaudo force-pushed the uppercase-builders-deprecate branch from 0a81046 to 27f28c2 Compare March 24, 2025 17:40
@nicolo-ribaudo nicolo-ribaudo force-pushed the uppercase-builders-deprecate branch from 27f28c2 to e17cf27 Compare March 24, 2025 18:10
@liuxingbaoyu
Copy link
Member

Would it be better to only warn once for the uppercase builder?
I'm concerned about having a few different nodes causing too many warnings to be output.

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Mar 24, 2025 •
edited
Loading

You mean once per builder, or once in general for all builders?

@liuxingbaoyu
Copy link
Member

liuxingbaoyu commented Mar 24, 2025 •
edited
Loading

Once in general for all builders, but it would be better to keep the specific node names. :)

Maybe add a cacheKey parameter to deprecationWarning.

@nicolo-ribaudo nicolo-ribaudo merged commit 0d098d7 into babel:main Mar 26, 2025
55 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the uppercase-builders-deprecate branch March 26, 2025 14:25
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 26, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Deprecation (next major) 📢 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate uppercase builders?
4 participants
@nicolo-ribaudo @babel-bot @liuxingbaoyu @JLHwung