fix: correctly resolve references to non-constant enum members #17050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
branchseer
commented
Jan 8, 2025
| Q | A |
|---|---|
| Fixed Issues? | Fixes #17049 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | Yes |
| Minor: New Feature? | No |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58540 |
|
CI is also failing on main -- it's unrelated to this PR |
|
Hi @nicolo-ribaudo, is this PR good to merge, or is there anything more to do? |
|
Usually we wait for a second approval from another maintainer, let's just wait a little bit longer :) |
JLHwung
reviewed
Jan 14, 2025
| return A; | ||
| })()) | ||
| } */ | ||
| return; |
There was a problem hiding this comment.
This part seems like something we should provide in the scope prototype for Babel 8. The Scope.prototype.hasBinding could accept an upToScope parameter where the scope search will end.
Boshen
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jan 15, 2025
Update babel submodule for conformance tests to latest HEAD. The test fixtures include a new one for a bug fix which @branchseer intends to also apply to Oxc - babel/babel#17050 (see #8342).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.