Skip to content

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

#16792 is adding an error in Babel 8 when specifying the option so that people notice that they can remove it. However, we can already ease the migration by enabling it by default in Babel 7.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories area: flow pkg: parser labels Sep 16, 2024
@nicolo-ribaudo nicolo-ribaudo added this to the v7.26.0 milestone Sep 16, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Sep 16, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58199

@liuxingbaoyu
Copy link
Member

I'm concerned that TS's allowDeclareFields might be difficult to align with this, because of #16373 (comment).
Or do we just always enable this alone.

@nicolo-ribaudo
Copy link
Member Author

I would do it just for this, since this is purely a new feature. That other one also changes behavior of existing code.

@nicolo-ribaudo nicolo-ribaudo added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release PR: Needs Docs labels Sep 17, 2024
@nicolo-ribaudo
Copy link
Member Author

No docs needed, as the enum option was not even documented 😅

@nicolo-ribaudo nicolo-ribaudo merged commit b8d6334 into babel:main Oct 23, 2024
52 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the flow-enums branch October 23, 2024 14:02
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 23, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: flow outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants