Skip to content

Move decorators parens logic to needsParens #16627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2024
Merged

Move decorators parens logic to needsParens #16627

merged 3 commits into from
Jul 10, 2024

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Polish 💅 A type of pull request used for our changelog categories pkg: generator Spec: Decorators labels Jul 10, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 10, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57300

@nicolo-ribaudo
Copy link
Member Author

@liuxingbaoyu I moved the logic to the needsParens function, please take a look again!

@nicolo-ribaudo nicolo-ribaudo removed the PR: Polish 💅 A type of pull request used for our changelog categories label Jul 10, 2024
@nicolo-ribaudo nicolo-ribaudo changed the title Avoid unnecessary parens in decorators with parenthesized callee Move decorators parens logic to needsParens Jul 10, 2024
@nicolo-ribaudo nicolo-ribaudo merged commit 7a27ff4 into babel:main Jul 10, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the dec-no-extra-parens branch July 10, 2024 22:05
@fisker fisker mentioned this pull request Jul 12, 2024
Merged
4 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator Spec: Decorators
Projects
None yet
Milestone
generator: preserveFormat
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @liuxingbaoyu