[Babel 8] Change scope.{references,uids} to Set
#16624
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59456 |
|
In fact, there are some potential problems with the current behavior. For example, when calling |
| references?: Set<string>; | ||
| globals: { [name: string]: t.Identifier | t.JSXIdentifier }; | ||
| uids: { [name: string]: boolean }; | ||
| uids?: Set<string>; |
There was a problem hiding this comment.
Can you add a comment saying that they are only defined in the program scope? Or maybe, we can simplify some methods by defining them in all scopes but using the same shared set.
|
@liuxingbaoyu Do you still want to do this? (I think we should) |
|
Yes I will continue it! |
|
If people miss the changelog from Babel 7 to Babel 8, they would have a confusing debug experience because from their point of view, I suggest we introduce |
|
Maybe could that getter also return a proxy that makes it work with the underlying set? |
|
Perhaps we could just rename |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Fixes #1, Fixes #2In addition to changing
scope.{references,uids}toSet, we also only create them at the top-level program scope, since we never use them in child scopes.I'm not sure if these two properties are public, but it would be good to mention it in the migration guide.