perf: avoid loadFullConfig when creating block hoist plugin #13223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45634/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a2f3002:
|
nicolo-ribaudo
approved these changes
Apr 26, 2021
hzoo
approved these changes
Apr 26, 2021
| @@ -9,14 +8,13 @@ export default function loadBlockHoistPlugin(): Plugin { | |||
| // Lazy-init the internal plugin to remove the init-time circular | |||
| // dependency between plugins being passed @babel/core's export object, | |||
| // which loads this file, and this 'loadConfig' loading plugins. | |||
There was a problem hiding this comment.
Nit: this comment needs to be updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of loading block hoist plugin. The benchmark is conducted after removing the
LOADED_PLUGINcache:For this reason I didn't add the benchmark files since the it can not be run without modifying the source.
Creating the plugin from constructor is 50x faster than hooking into
loadConfig. However, since we already cache it, it would probably not have any real world performance changes. The benefit of this PR is that we don't have to maintain the parameters ofloadConfig.sync.