Skip to content

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Currently we first print the user's targets, and then we print again the same targets next to each plugin.

This PR modify what we print next to each plugin, by making it for example "this plugin is needed for chrome < 71" rather than "this plugin is needed because your targets include chrome 30". By doing so, it's easier to see how changes in the target browser can affect the loaded plugins.

@nicolo-ribaudo nicolo-ribaudo added PR: Polish 💅 A type of pull request used for our changelog categories pkg: preset-env labels Apr 7, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 7, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45084/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ee87fc9:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

transform-unicode-regex { ios < 12, safari < 12 }
transform-block-scoping { ios < 11, safari < 11 }
proposal-export-namespace-from { android < 72, chrome < 72, edge < 79, firefox < 80, ios, opera < 60, safari, samsung < 11.0 }
transform-modules-commonjs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we would want to special case these (mention modules option?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a follow-up PR for this 👍

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, good idea to give more info instead of repeating

proposal-export-namespace-from {}
syntax-numeric-separator
syntax-nullish-coalescing-operator
proposal-optional-chaining { chrome }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing, but I guess this is confusing without looking at the data, that it's because you need to add bugfixes? Seems like it implies chrome doesn't support it.

Guess it'll sorta be fixed when we make it default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no version of chrome supports optional chaining unless you enable bugfixes.

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nicolo-ribaudo nicolo-ribaudo merged commit be1003b into babel:main Apr 7, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the debug-output-show-support-version branch April 7, 2021 20:50
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants