Skip to content

Enable class fields & private methods by default #13091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2021
Merged

Enable class fields & private methods by default #13091

merged 2 commits into from
Apr 21, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 2, 2021 •
edited
Loading

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

It stage 4 now 🎉

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser labels Apr 2, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 2, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45512/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 2, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 548a96f:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review April 2, 2021 17:40
@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.14.0/parser-updates April 3, 2021 17:34
@nicolo-ribaudo nicolo-ribaudo force-pushed the class-features-enable-default branch from a637c70 to 4264838 Compare April 3, 2021 17:43
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.14.0/parser-updates branch 2 times, most recently from 23693e2 to b1381d1 Compare April 13, 2021 14:42
@nicolo-ribaudo nicolo-ribaudo added this to the v7.14.0 milestone Apr 14, 2021
@JLHwung JLHwung force-pushed the feat-7.14.0/parser-updates branch 3 times, most recently from 4d58f86 to 654ab5a Compare April 19, 2021 19:40
@nicolo-ribaudo nicolo-ribaudo force-pushed the class-features-enable-default branch from 4264838 to 0bd1fa5 Compare April 19, 2021 20:29
@nicolo-ribaudo nicolo-ribaudo changed the base branch from feat-7.14.0/parser-updates to feat-7.14.0/preset-env April 19, 2021 20:29
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 19, 2021
Merged
5 tasks
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.14.0/preset-env branch from 838211b to d7d910a Compare April 20, 2021 21:39
@nicolo-ribaudo nicolo-ribaudo force-pushed the class-features-enable-default branch from 0bd1fa5 to 3d91dd2 Compare April 20, 2021 22:21
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.14.0/preset-env branch from 6e9c515 to 8e5ff36 Compare April 21, 2021 13:56
@nicolo-ribaudo nicolo-ribaudo force-pushed the class-features-enable-default branch from 3d91dd2 to 857272b Compare April 21, 2021 13:58
@nicolo-ribaudo nicolo-ribaudo force-pushed the class-features-enable-default branch from 857272b to 548a96f Compare April 21, 2021 16:28
@nicolo-ribaudo nicolo-ribaudo merged commit a40f085 into babel:feat-7.14.0/preset-env Apr 21, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the class-features-enable-default branch April 21, 2021 17:11
nicolo-ribaudo added a commit that referenced this pull request Apr 28, 2021
@nicolo-ribaudo
Enable class fields & private methods by default (#13091)
b4c21c7
@wentwrong wentwrong mentioned this pull request Apr 30, 2021
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
v7.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nicolo-ribaudo @babel-bot @jridgewell @hzoo @JLHwung