Skip to content

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 28, 2021

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

There is probably a rollup bug, which makes the "old Babel" e2e test fail on main.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 646a17f:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 28, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47640/

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jul 28, 2021

Ok, also updating @rollup/plugin-commonjs fixes the problem.

@nicolo-ribaudo
Copy link
Member Author

Rollup bugs: rollup/plugins#962, rollup/rollup#4195

@nicolo-ribaudo
Copy link
Member Author

Closing until the Rollup bug is fixed

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants