-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix(parser): add missing @babel/types dependency #11118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm wondering how it's possible that I didn't notice it while testing yarn 2 on this repository 🤔 |
It's only required in the typescript types. babel/packages/babel-parser/typings/babel-parser.d.ts Lines 8 to 16 in 143d159
|
Oh right, I forgot about it. Related: #10315, #9924. I don't think that we should add a whole dependency only used for TS types. I think that we have 3 options:
cc @babel/babel |
Is there an |
It was in my search history and I assumed that it existed 😅
We are dropping Node.js <10.13 in Babel 8, and v10.13.0 has npm v6.12.0 which supports peerDepsMeta. However, I think that this is sub-optimal and I would prefer my third suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merceyz:parser-types #11118 parser-types
Jest (@SimenB) is testing Yarn 2 (jestjs/jest#9476) and their TypeScript build failed because
@babel/parser
is missing a dependency on@babel/types
.