-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Closed
Labels
Has PRclaimedgood first issueoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue
Description
Feature Request
This means that it should be enabled by default in @babel/parser
🎉
It should be done similarly to this commit: 24c4901
- Remove all the
this.hasPlugin
andthis.expectPlugin
checks related to this plugin inpackages/babel-parser/src
- Remove all the usages of
optionalChaining
in@babel/parser
's tests - Probably there is a test to ensure that the plugin is required; it can be removed.
- Move the tests from the
experimental
folder toes2020
- PR! 🎉
If it is the first time that you contribute to Babel, follow these steps: (you need to have make
and yarn
available on your machine)
- Write a comment there to let other possible contributors know that you are working on this bug.
- Fork the repo
- Run
git clone https://github.com/<YOUR_USERNAME>/babel.git && cd babel
- Run
yarn && make bootstrap
- Wait ⏳
- Run
make watch
(ormake build
whenever you change a file) - Add a test if needed (only
input.js
;output.js
will be automatically generated) - Update the code!
yarn jest babel-parser
to run the tests- If some test outputs don't match but the new results are correct, you can delete the bad
output.js
files and run the tests again - If you prefer, you can run
OVERWRITE=true yarn jest babel-parser
and they will be automatically updated.
- If some test outputs don't match but the new results are correct, you can delete the bad
- If it is working, run
make test
to run all the tests - Run
git push
and open a PR!
markozxuu, TheAlexLichter, Frozen-byte and NMinhNguyenniklaskorz and markozxuumarkozxuumarkozxuu and wojtekmaj
Metadata
Metadata
Assignees
Labels
Has PRclaimedgood first issueoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issue