-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Closed
Labels
Has PRgood first issuehelp wantedoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issuepkg: generator
Milestone
Description
(breaking change)
Going to start out by saying babel-generator
is the package that takes an AST from the babel plugin/presets and returns a string (your file). As a compile file you probably shouldn't be caring that much about the options here. You're going to minify it in prod as well and it's not the source code where you would use eslint, prettier, etc.
Thus out of the options currently in generator - https://github.com/babel/babel/tree/master/packages/babel-generator#options, the quotes
one doesn't make sense because the others have to do with code coverage, minification, or sourcemaps.
This also would fix #4803 (fixing the issue by removing the option)
- Comment below you are going to do this (for others to know)
- Read CONTRIBUTING.md
- Check you are on 7.0 branch with
git checkout 7.0
and then make a branch off of that to PR - Join our slack if you haven't already if you need more immediate help or just comment in this issue/PR
- remove quotes option from babel-generator (readme, src, tests)
-
quotes: opts.quotes || findCommonStringDelimiter(code, tokens), -
quotes: "single" | "double"; - might not have tests in my initial check which is probably why custom quotes option is broken down #4803
-
existentialism
Metadata
Metadata
Assignees
Labels
Has PRgood first issuehelp wantedoutdatedA closed issue/PR that is archived due to age. Recommended to make a new issueA closed issue/PR that is archived due to age. Recommended to make a new issuepkg: generator