fixed issue with yarn plugin hooks always failing #30390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys fall silently + existing implementation did not do anything, because executing `getPackageVersion` always resulted in an error that was then silently suppressed Signed-off-by: eipc16 <pprzemek.312@gmail.com>
Unnecessary ChangesetsThe following package(s) are private and do not need a changeset:
Changed Packages
|
eipc16
commented
Jun 25, 2025
Comment on lines
-34
to
+35
| try { | ||
| await getPackageVersion(toDescriptor, workspace.project.configuration); | ||
| console.warn( | ||
| `${toDescriptor.name} should be set to "${PROTOCOL}^" instead of "${toDescriptor.range}". Make sure this change is intentional and not a mistake.`, | ||
| ); | ||
| } catch (_error: any) { | ||
| // if there's no found version then this is likely a deprecated package | ||
| // or otherwise the plugin won't be able to resolve the real version | ||
| // and we should not warn them. | ||
| } | ||
| console.warn( | ||
| `${toDescriptor.name} should be set to "${PROTOCOL}^" instead of "${toDescriptor.range}". Make sure this change is intentional and not a mistake.`, | ||
| ); |
There was a problem hiding this comment.
I was not sure what do to do with it tbh? Previous implementation did not make much sense and the descriptor for the hook should only display a warning... so now it does
2 tasks
freben
reviewed
Jun 25, 2025
There was a problem hiding this comment.
The changes seem to make sense to me, but that's coming from someone who's not intimately familiar with yarn plugin development. @benjdlambert looking good to 🚢 ?
packages/yarn-plugin/src/handlers/afterWorkspaceDependencyAddition.test.ts
Outdated
Show resolved
Hide resolved
benjdlambert
approved these changes
Jun 25, 2025
…alled in tests Update packages/yarn-plugin/src/handlers/afterWorkspaceDependencyAddition.test.ts Co-authored-by: Fredrik Adelöw <freben@gmail.com> Signed-off-by: Przemek <32961666+eipc16@users.noreply.github.com>
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This should fix an issue where new dependencies where not added with backstage:^ protocol, because new yarn hooks were always failing silently. Explanation here: #30083 (comment)
✔️ Checklist
Signed-off-byline in the message. (more info)