Skip to content

feat(catalog)!: remove catalog.useUrlReadersSearch and always use search #29788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

feat(catalog)!: remove catalog.useUrlReadersSearch and always use search #29788

merged 1 commit into from
Jun 19, 2025

Conversation

tcardonne
Copy link
Contributor

Hey, I just made a Pull Request!

Follow-up of #28379.

Removes the experimental (but encouraged to use)catalog.useUrlReadersSearch configuration flag introduced in v1.36.

Also removes the old behavior that checks if the given Git-parsed URL contains pattern-like characters and calls readUrl or search accordingly. The new behavior is to always use the search and let readers decide if it contains a pattern or not.

Notes

This was discussed in today's (29th april) SIG Framework meeting, and given it's a breaking change it may be a good idea to include this as part of the catalog backend's breaking changes (@freben).

I opened this PR so this can be discussed 👍

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@tcardonne tcardonne requested review from a team as code owners April 29, 2025 16:50
@github-actions github-actions bot added the area:catalog Related to the Catalog Project Area label Apr 29, 2025
@backstage-goalie
Copy link
Contributor

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/create-app packages/create-app patch v0.6.2-next.1
@backstage/plugin-catalog-backend plugins/catalog-backend major v2.0.0-next.1

@tcardonne tcardonne force-pushed the feat-remove-useurlreaderssearch branch from 7992fe7 to be41cab Compare April 29, 2025 16:51
@tcardonne
feat(catalog)!: remove catalog.useUrlReadersSearch and always use search
2339363 
Signed-off-by: Thomas Cardonne <thomas.cardonne@adevinta.com>
@tcardonne tcardonne force-pushed the feat-remove-useurlreaderssearch branch from be41cab to 2339363 Compare April 29, 2025 16:59
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 13, 2025
@freben freben removed the stale label May 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 27, 2025
@freben freben removed the stale label May 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jun 10, 2025
@freben freben removed the stale label Jun 10, 2025
@freben freben self-requested a review June 10, 2025 21:34
@Rugvip Rugvip added the workflow:after-release This is a bit too scary to merge until after the next release label Jun 17, 2025
@freben freben merged commit 6d9a4dd into backstage:master Jun 19, 2025
29 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.41.0 release, scheduled for Tue, 15 Jul 2025.

@benjdlambert benjdlambert mentioned this pull request Jul 15, 2025
Merged
@Rugvip Rugvip mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freben freben freben approved these changes

@benjdlambert benjdlambert Awaiting requested review from benjdlambert benjdlambert is a code owner automatically assigned from backstage/maintainers

@vinzscam vinzscam Awaiting requested review from vinzscam vinzscam is a code owner automatically assigned from backstage/reviewers

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

Assignees
No one assigned
Labels
area:catalog Related to the Catalog Project Area workflow:after-release This is a bit too scary to merge until after the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcardonne @freben @Rugvip