Remove abstraction - Part 1 easy mode #1014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's discuss first in #1015 before moving forward here. |
|
In light of the recent development (merge core/web) I still think this PR makes sense. |
97e3083 to
093a79f
Compare
|
On second thought - let's tackle that once it's merged to reduce waste/noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The motivation for this was pretty simple:
IRenderedComponentBaseandIRenderedComponentdo share 100% overlap in their public API. So I merged them both together and remove theBasesuffix inbunit.core. I don't thinkBaseis a good name for an interface anyway. We are talking about operating contracts and not abstract classes.Anyway, this is the first PR that aims to unify some of our core types. I will create an additional issue for that so we can discuss our ideas and design further.
I do believe (however we decide which abstracts we need) that it makes sense to merge those two types - as they were virtually the same until now.
PS: We should merge
mainintov2to get rid of those pesty new Analyzer issues you already fixed onmain.