Skip to content

Implement reading of other data streams into Frame using FFmpegFrameGrabber #1377 #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2020
Merged

Implement reading of other data streams into Frame using FFmpegFrameGrabber #1377 #1378

merged 3 commits into from
Feb 17, 2020

Conversation

bytes-and-bits
Copy link
Contributor

This implements #1377

@bytes-and-bits bytes-and-bits requested a review from saudet February 8, 2020 06:40
saudet
saudet reviewed Feb 8, 2020
View reviewed changes
saudet
saudet reviewed Feb 13, 2020
View reviewed changes
@bytes-and-bits
Copy link
Contributor Author

Any other changes you would like me to make?

@saudet
Copy link
Member

saudet commented Feb 17, 2020

Just one more small thing I think, but it's easier simply to push changes to your fork, so I'll do that. Thanks!

@saudet
Allow users to disable grabbing data frames with new grabFrame() para…
7fe4ebf 
…meter

Also update CHANGELOG.md and fix formatting
@bytes-and-bits
Copy link
Contributor Author

Did a quick check of your changes against the test videos I've been using and everything looks good.

@saudet saudet merged commit 1101631 into bytedeco:master Feb 17, 2020
@bytes-and-bits bytes-and-bits deleted the otherstreams branch February 18, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudet saudet saudet left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bytes-and-bits @saudet