-
-
Notifications
You must be signed in to change notification settings - Fork 751
Update oneDNN (DNNL) to 3.8.1., which fixes reorder primitive #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s broken from 3.7.0.
Thank you! Please upgrade the version in other dependent presets as well |
Upgraded. Please note that dnnl is used in onnxruntime (which I updated) and tvm. But, tvm as it is used a very old version of dnnl (2.7.1), and tvm itself is still on javacpp 1.5.11, so I didn't change it. |
Please also note that onnxruntime build is failing in github actions now due to dnnl 3.8.1-1.5.12-SNAPSHOT preset is not yet present in the central repository. I don't know whether that's expected, or I can do something about that. |
Right, we'll need to test that some other way, probably by using a branch here I guess. Anyway, please update all the versions, including on this line: |
As far as I can see, that's only a removal of a trailing space in the markdown doc. I didn't even do it myself, it was probably done automatically by some of the tools. I can discard that if it's necessary, but is it really an issue? |
Revert the trailing space edit in Readme.md.
I (hopefully) fixed the required issues in code. |
My Clojure code (which extensively uses dnnl, even the exotic parts) passes more than a thousand tests... |
Update oneDNN (DNNL) to 3.8.1., which fixes reorder primitive that was broken since 3.7.0.