Skip to content

Conversation

blueberry
Copy link
Contributor

Update oneDNN (DNNL) to 3.8.1., which fixes reorder primitive that was broken since 3.7.0.

@saudet
Copy link
Member

saudet commented May 28, 2025

Thank you! Please upgrade the version in other dependent presets as well

@blueberry
Copy link
Contributor Author

Upgraded. Please note that dnnl is used in onnxruntime (which I updated) and tvm. But, tvm as it is used a very old version of dnnl (2.7.1), and tvm itself is still on javacpp 1.5.11, so I didn't change it.

@blueberry
Copy link
Contributor Author

Please also note that onnxruntime build is failing in github actions now due to dnnl 3.8.1-1.5.12-SNAPSHOT preset is not yet present in the central repository. I don't know whether that's expected, or I can do something about that.

@saudet
Copy link
Member

saudet commented May 28, 2025

Right, we'll need to test that some other way, probably by using a branch here I guess. Anyway, please update all the versions, including on this line:
https://github.com/bytedeco/javacpp-presets/blob/master/onnxruntime/cppbuild.sh#L101

@blueberry
Copy link
Contributor Author

As far as I can see, that's only a removal of a trailing space in the markdown doc. I didn't even do it myself, it was probably done automatically by some of the tools. I can discard that if it's necessary, but is it really an issue?

@blueberry
Copy link
Contributor Author

I (hopefully) fixed the required issues in code.

@blueberry
Copy link
Contributor Author

blueberry commented May 28, 2025

My Clojure code (which extensively uses dnnl, even the exotic parts) passes more than a thousand tests...

@saudet saudet merged commit 8ae25db into bytedeco:master May 31, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants