Skip to content

fix: some lint fix using tools #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 12, 2025
Merged

fix: some lint fix using tools #98

merged 7 commits into from
Jul 12, 2025

Conversation

yihong0618
Copy link
Contributor

This patch using some tools to make the format better

  • using ruff to drop useless import
  • using typos to fix a typo in src/
  • using autocorrect to lint README CN to make it beautiful
  • using markdownlint to lint markdown

@CLAassistant
Copy link

CLAassistant commented May 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hetaoBackend
Copy link
Collaborator

That's super cool, thanks for helping lint the codebase, could u plz rebase the latest code? Thanks in advance! BTW, it might be a good idea to add ruff check in the current make lint command?

@yihong0618
Copy link
Contributor Author

That's super cool, thanks for helping lint the codebase, could u plz rebase the latest code? Thanks in advance! BTW, it might be a good idea to add ruff check in the current make lint command?

will do it tomorrow

yihong0618 added 3 commits May 19, 2025 09:51
@yihong0618
fix: some lint fix using tools
4586fa8 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
fix: md lint
c333b93 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
fix: some lint fix using tools
6aa1e44 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
fix: address comments
3ba054a 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618
Copy link
Contributor Author

That's super cool, thanks for helping lint the codebase, could u plz rebase the latest code? Thanks in advance! BTW, it might be a good idea to add ruff check in the current make lint command?

@hetaoBackend addressed the comments

yihong0618 and others added 2 commits May 19, 2025 10:07
@yihong0618
fix: tests
84af829 
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@WillemJiang
Merge branch 'main' into hy/some_lint_fix
4e048f2
WillemJiang
WillemJiang reviewed Jul 12, 2025
View reviewed changes
src/config/__init__.py
@@ -2,7 +2,6 @@
# SPDX-License-Identifier: MIT

from .tools import SELECTED_SEARCH_ENGINE, SearchEngine
from .loader import load_yaml_config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important for loading the YAML config in the system; we need to export this method.

@WillemJiang
Copy link
Collaborator

@yihong0618 Thanks for the contribution.
Some other lint errors will be fixed in the next commit.

@WillemJiang WillemJiang merged commit 2363b21 into bytedance:main Jul 12, 2025
1 of 3 checks passed
@yihong0618
Copy link
Contributor Author

@yihong0618 Thanks for the contribution.

Some other lint errors will be fixed in the next commit.

thank you

dangphdh pushed a commit to dangphdh/deer-flow that referenced this pull request Jul 13, 2025
@yihong0618 @WillemJiang @dangphdh
fix: some lint fix using tools (bytedance#98)
b993234 
* fix: some lint fix using tools

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

* fix: md lint

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

* fix: some lint fix using tools

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

* fix: address comments

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

* fix: tests

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

---------

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillemJiang WillemJiang WillemJiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yihong0618 @CLAassistant @hetaoBackend @WillemJiang