Pass operand types in to Wasm-to-CLIF translation #11030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With bytecodealliance/wasm-tools#2237, this is now passing all tests locally, so I'll cut a wasm-tools release, update those crates in this repo, and then this PR can rebase and merge. |
|
wasm-tools dep update in #11034 |
0dcc3fa to
6a04cb3
Compare
alexcrichton
approved these changes
Jun 13, 2025
This lets us generate better CLIF based on what we know of the Wasm types. There is a bunch we can do here, but this commit just lays down the initial infrastructure and plumbs the type info through to the `ref.is_null` implementation. We will now avoid actually performing null check when the input to a `ref.is_null` instruction is a non-nullable ref type.
6a04cb3 to
de97486
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us generate better CLIF based on what we know of the Wasm types. There is a bunch we can do here, but this commit just lays down the initial infrastructure and plumbs the type info through to the
ref.is_nullimplementation. We will now avoid actually performing null check when the input to aref.is_nullinstruction is a non-nullable ref type.Note that this depends on a fix for bytecodealliance/wasm-tools#2235 and then a new
wasm-toolsrelease.