asm: customize Mnemonic
and Display
separately
#11017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we just want to fix up the printed name of the instruction in the disassembly; e.g., instructions with the
lock
prefix. But, as we're seeing in #10836 and elsewhere, other times we want to control the printing of the entire instruction--the fullDisplay
implementation. We'll need this kind of thing if we want to swap the order of operands or omit an immediate if it ends up being included in the printed instruction name.This change splits this kind of customization in two:
Mnemonic
andDisplay
. After renaming this enum toCustomization
, all existing uses ofDisplay
are migrated toMnemonic
.