Skip to content

winch: Run more spec tests #11013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

winch: Run more spec tests #11013

merged 3 commits into from
Jun 11, 2025

Conversation

alexcrichton
Copy link
Member

This commit removes the configuration in Wasmtime indicating that Winch panics on aarch64 with the simd proposal for WebAssembly. This means that many more spec tests can be run by default since they're all, by default, flagged as requiring simd at this time. This in turn means that many more tests needed to be added to the list of "expected to fail" tests for Winch on aarch64 (the ones that actually use simd). One minor panic was fixed as a result of this as well to ensure that tests do indeed run without panicking.

@alexcrichton
winch: Run more spec tests
b490785 
This commit removes the configuration in Wasmtime indicating that Winch
panics on aarch64 with the simd proposal for WebAssembly. This means
that many more spec tests can be run by default since they're all, by
default, flagged as requiring simd at this time. This in turn means that
many more tests needed to be added to the list of "expected to fail"
tests for Winch on aarch64 (the ones that actually use simd). One minor panic
was fixed as a result of this as well to ensure that tests do indeed run
without panicking.
@alexcrichton alexcrichton requested review from a team as code owners June 11, 2025 15:13
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team June 11, 2025 15:13
@fitzgen fitzgen added this pull request to the merge queue Jun 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2025
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime winch Winch issues or pull requests labels Jun 11, 2025
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions GitHub Actions
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.

More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.

Is this method fallible? If so, when can it return an error?

Can this method panic? If so, when does it panic?

# Example

Optional example here.

  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@alexcrichton alexcrichton enabled auto-merge June 11, 2025 18:17
@alexcrichton alexcrichton added this pull request to the merge queue Jun 11, 2025
Merged via the queue into bytecodealliance:main with commit f163a6c Jun 11, 2025
41 checks passed
@alexcrichton alexcrichton deleted the winch-more-support branch June 11, 2025 18:51
saulecabrera added a commit to saulecabrera/wasmtime that referenced this pull request Jun 12, 2025
@saulecabrera
winch(aarch64) Run integration tests in winch-aarch64
d13d1cf 
This commit closes
bytecodealliance#8321

With bytecodealliance#11013, Winch
passes all spec tests for Core Wasm on Aarch64.
@saulecabrera saulecabrera mentioned this pull request Jun 12, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 16, 2025
@saulecabrera
winch(aarch64) Run integration tests in winch-aarch64 (#11031)
60269d6 
* winch(aarch64) Run integration tests in winch-aarch64

This commit closes
#8321

With #11013, Winch
passes all spec tests for Core Wasm on Aarch64.

* Run `cargo fmt`

* Add an `integration` option to `TestConfig`

`wast::TestConfig` is shared across spec tests and integration tests,
this commits adds a flag to identify if the config is for integration
test purposes making it easier to contextually decide if tests are
expected to fail or pass depending on the Wasm configuration options.

* Use `spec_test` instead of `integration`

To better differentiate spec tests from integration tests

* Ensure only aarch64 / x64 when testing Winch

* Revert directive for typed_v128 test

Put back `#[wasmtime_test(wasm_features(simd),
strategies(not(Winch)))]`; the reason why this tests shouldn't run
with Winch is because it requires AVX, but we can have a generic rule
at the test config level since not all SIMD based tests require AVX,
it really depends on which SIMD instructions are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

@saulecabrera saulecabrera Awaiting requested review from saulecabrera

Assignees
No one assigned
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime winch Winch issues or pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @fitzgen