Update DWARF tests to Ubuntu 24.04 #11077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gdb version in Ubuntu 24.04 fails on our synthetic DWARF because: 1. the synthetic DWARF unit has no DW_AT_language 2. synthetic types are referenced from a unit that does have DW_AT_language 3. this triggers https://sourceware.org/bugzilla/show_bug.cgi?id=32431 Workaround this issue by specifying DW_LANG_C11. This may not be exactly the right meaning, but it should be safe.
abrown
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
This all seems reasonable to me as it updates tools to more recent versions. I'm no DWARF expert, though, so I'll leave this open for a bit in case @alexcrichton or @fitzgen have any stronger opinions about the C11 decision.
|
Thanks @philipc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gdb version in Ubuntu 24.04 fails on our synthetic DWARF because:
Workaround this issue by specifying DW_LANG_C11. This may not be exactly the right meaning, but it should be safe.
Closes #9731
I would like this change because my development system has this gdb version.