Add function names to --emit-clif output #11040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 13, 2025
crates/cranelift/src/compiler.rs
Outdated
Comment on lines
1007
to
1008
| ";;Intermediate Representation of function <{}>:\n", | ||
| symbol.split("::").last().unwrap() |
There was a problem hiding this comment.
This would work too, right?
Suggested change
| ";;Intermediate Representation of function <{}>:\n", | |
| symbol.split("::").last().unwrap() | |
| ";; Intermediate Representation of function <{symbol}>:\n", |
This avoids truncating a function name like wasm[0]::function[1]::my_library::SomeType::get (as would be used if the names section contains my_library::SomeType::get as name) to the pretty much useless get.
There was a problem hiding this comment.
would using something like this function work better?
fn remove_first_two_segments(s: &str) -> Option<String> {
let mut parts = s.split("::").skip(2);
let rest: Vec<&str> = parts.collect();
if rest.is_empty() {
None
} else {
Some(format!("::{}", rest.join("::")))
}
}also wasmtime explore uses "Intermediate Representation of function :" too should i figure out a way where it gives my_library::SomeType::get too?
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes: #10733
Explanation
This PR addresses issue #10733 by adding the function name as a comment to the beginning of each Cranelift IR file generated by the
--emit-clifflag.Previously, the files generated by
--emit-clifcontained only the raw Cranelift IR, making it difficult to identify which function the IR belonged to without cross-referencing with other tools likewasmtime explore. This change improves the usability of the--emit-clifoutput by clearly labeling each function's IR.Input Needed
I'm unsure of where to place tests for this.