Simplify and optimize the way that enums are passed in fused adapters
#10939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of treating them like variants that don't have payloads, just check that the discriminant is in bounds.
alexcrichton
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
If you're feeling particularly enterprising, mind adding a test to tests/misc_testsuite/component-model/*.wast? I think it should be reasonably easy to hook this all up and we could assert that traps don't happen for in-bounds values but do happen for out-of-bounds values
I'll give this a shot in a follow up PR |
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jun 6, 2025
This commit fixes two issues: (1) is that `--emit-clif` generates file names that are different from symbol names and (2) is that `--emit-clif` for components today has collisions on filenames which means that output files can get corrupted. Currently (2) is causing spurious failures in CI due to the test added in bytecodealliance#10939 being the first test with a component and functions in modules where they clash to emit the same file.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
* Align symbol names with `--emit-clif` This commit fixes two issues: (1) is that `--emit-clif` generates file names that are different from symbol names and (2) is that `--emit-clif` for components today has collisions on filenames which means that output files can get corrupted. Currently (2) is causing spurious failures in CI due to the test added in #10939 being the first test with a component and functions in modules where they clash to emit the same file. * Fix typo * Fix tests * Fix tests on Windows Can't use `:` in filenames on Windows prtest:full
dicej
pushed a commit
to dicej/wasmtime
that referenced
this pull request
Jun 9, 2025
This commit fixes two issues: (1) is that `--emit-clif` generates file names that are different from symbol names and (2) is that `--emit-clif` for components today has collisions on filenames which means that output files can get corrupted. Currently (2) is causing spurious failures in CI due to the test added in bytecodealliance#10939 being the first test with a component and functions in modules where they clash to emit the same file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of treating them like variants that don't have payloads, just check that the discriminant is in bounds.